Re: [PATCH 4/4] compat: add some tracing backport work

From: Luis R. Rodriguez
Date: Wed Mar 28 2012 - 06:00:41 EST

On Mon, Mar 26, 2012 at 08:58:22AM -0400, Luis R. Rodriguez wrote:
> On Mon, Mar 26, 2012 at 10:49:28AM +0200, Johannes Berg wrote:
> > On Wed, 2012-03-21 at 21:29 -0700, Luis R. Rodriguez wrote:
> >
> > > But no dice. I then figured it may be my kernel with
> > > CONFIG_TRACEPOINTS=y and indeed that is the case -- so we have to
> > > consider the case where the target kernel may have tracing enabled and
> > > we have to disable it somehow. Undef'ing CONFIG_TRACEPOINTS and
> > > DECLARE_TRACE doesn't really do it.
> >
> > Oh, ok, yuck. So I guess we can't easily disable tracing if it's enabled
> > in the base kernel ...
> Its a bit tough.

I've managed to backport tracing it seems, even when CONFIG_TRACEPOINTS
is enabled. The patch below covers that. I'll spew out the latest
error log on compaling compat-wireless though, this is down on

/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c: In function âif_sdio_power_onâ:
/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c:771:19: warning: unused variable âhostâ
/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c: In function âif_sdio_power_saveâ:
/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c:1071:2: error: implicit declaration of function âpm_runtime_put_syncâ
/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c: In function âif_sdio_power_restoreâ:
/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c:1081:2: error: implicit declaration of function âpm_runtime_get_syncâ
/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c: In function âif_sdio_probeâ:
/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c:1231:2: error: implicit declaration of function âpm_runtime_put_noidleâ
/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c: In function âif_sdio_removeâ:
/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.c:1268:2: error: implicit declaration of function âpm_runtime_get_noresumeâ
make[4]: *** [/home/mcgrof/devel/compat-wireless/drivers/net/wireless/libertas/if_sdio.o] Error 1

This compilation issue is not related to tracing and seems trivial to
resolve. So hey this is great progress..