Re: [PATCH 0/6] buffered write IO controller in balance_dirty_pages()
From: KAMEZAWA Hiroyuki
Date: Wed Mar 28 2012 - 20:35:56 EST
(2012/03/28 21:13), Fengguang Wu wrote:
> Here is one possible solution to "buffered write IO controller", based on Linux
> git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux.git buffered-write-io-controller
> - support blkio.weight
> - support blkio.throttle.buffered_write_bps
> - it's trivial to support per-bdi .weight or .buffered_write_bps
> 1) simple
> 2) virtually no space/time overheads
> 3) independent of the block layer and IO schedulers, hence
> 3.1) supports all filesystems/storages, eg. NFS/pNFS, CIFS, sshfs, ...
> 3.2) supports all IO schedulers. One may use noop for SSDs, inside virtual machines, over iSCSI, etc.
> 1) don't try to smooth bursty IO submission in the flusher thread (*)
> 2) don't support IOPS based throttling
> 3) introduces semantic differences to blkio.weight, which will be
> - working by "bandwidth" for buffered writes
> - working by "device time" for direct IO
> (*) Maybe not a big concern, since the bursties are limited to 500ms: if one dd
> is throttled to 50% disk bandwidth, the flusher thread will be waking up on
> every 1 second, keep the disk busy for 500ms and then go idle for 500ms; if
> throttled to 10% disk bandwidth, the flusher thread will wake up on every 5s,
> keep busy for 500ms and stay idle for 4.5s.
> The test results included in the last patch look pretty good in despite of the
> simple implementation.
yes, seems very good.
> [PATCH 1/6] blk-cgroup: move blk-cgroup.h in include/linux/blk-cgroup.h
> [PATCH 2/6] blk-cgroup: account dirtied pages
> [PATCH 3/6] blk-cgroup: buffered write IO controller - bandwidth weight
> [PATCH 4/6] blk-cgroup: buffered write IO controller - bandwidth limit
> [PATCH 5/6] blk-cgroup: buffered write IO controller - bandwidth limit interface
> [PATCH 6/6] blk-cgroup: buffered write IO controller - debug trace
> The changeset is dominated by the blk-cgroup.h move.
> The core changes (to page-writeback.c) are merely 77 lines.
> block/blk-cgroup.c | 27 +
> block/blk-cgroup.h | 364 --------------------------
> block/blk-throttle.c | 2
> block/cfq.h | 2
> include/linux/blk-cgroup.h | 396 +++++++++++++++++++++++++++++
> include/trace/events/writeback.h | 34 ++
> mm/page-writeback.c | 77 +++++
> 7 files changed, 530 insertions(+), 372 deletions(-)
Thank you very much. I like this simple implementation.
I have 3 questions..
- Do you have any plan to enhance this to support hierarchical accounting ?
- Can we get wait-time-for-dirty-pages summary per blkio cgroup ?
- Can we get status (dirty/sec) per blkio cgroup ?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/