Re: suppress page allocation failure warnings from sys_listxattr
From: Dave Jones
Date: Wed Mar 28 2012 - 20:54:52 EST
On Wed, Mar 28, 2012 at 04:47:20PM -0700, Andrew Morton wrote:
> On Wed, 28 Mar 2012 15:39:51 +1100
> Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > > Well, the unusual thing was that I was fuzzing system calls for a few hours.
> > >
> > > My fuzzing tool was able to trigger these very easily after an hour or two
> > > of uptime and memory had fragmented a little, so yeah, quite trivial.
> > We've recently been seeing reports of xfsdump trigging a similar
> > allocation failures in the XFS attr code when we are doing hundreds
> > of thousands of attribute lookups to back them up.
> > ad650f5 xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get
> > I think that falling back to vmalloc here is much better solution
> > than failing to retreive the attribute - it will work no matter how
> > fragmented memory gets. That means we don't get incomplete
> > backups occurring after days or months of uptime and successful
> > backups...
> Yup. How does the below look?
Don't see anything immediately wrong with it.
Any thoughts on what to do about the similar problem in setxattr ? (memdup_user)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/