Re: [PATCH v12 2/3] ARM: EXYNOS: Change System MMU platform devicedefinitions

From: Kukjin Kim
Date: Wed Mar 28 2012 - 21:23:54 EST

Joerg Roedel wrote:
On Fri, Mar 16, 2012 at 01:47:50PM -0700, Kukjin Kim wrote:
Anyway Joerg, how do you want to handle this? Do you want to pick up
1/2/3 all of them in your tree? If so, 2nd patch should be on top of
some samsung topic stuff.

Since patch 2 only applies to the Samsung tree, it is best to carry
this in your tree for merging. Feel free to add my Acked-by to patch 3.
But any further patches for the Exynos IOMMU drivers should go through
my tree after it is merged.

Hi Joerg,

Now that 1st and 2nd can be applied cleanly into latest mainline. But unfortunately, I have no chance to send them to Linus now and I'm not sure you can do it during this merge window. If it is possible, please keep going on with my ack.

KyongHo, just note, happens follwoing complaint with checkpatch, but I'm not sure this should be fixed right now. I think, if required, we can fix it later.

ERROR: Macros with complex values should be enclosed in parenthesis
#698: FILE: arch/arm/mach-exynos/dev-sysmmu.c:64:
+#define DEFINE_SYSMMU_RESOURCE(core, mem, irq) \
+ DEFINE_RES_MEM_NAMED(core##_PA_SYSMMU_##mem, SZ_4K, #mem), \
+ DEFINE_RES_IRQ_NAMED(core##_IRQ_SYSMMU_##irq##_0, #mem)

ERROR: Macros with complex values should be enclosed in parenthesis
#702: FILE: arch/arm/mach-exynos/dev-sysmmu.c:68:
+#define SYSMMU_RESOURCE_DEFINE(core, ipname, mem, irq) \
+ SYSMMU_RESOURCE(core, ipname) { \
+ DEFINE_SYSMMU_RESOURCE(core, mem, irq) \
+ }

WARNING: quoted string split across lines
#914: FILE: arch/arm/mach-exynos/dev-sysmmu.c:259:
+ pr_err("%s: Failed to add device resources for "
+ "%s.%d\n", __func__,

total: 2 errors, 1 warnings, 1062 lines checked


Best regards,
Kukjin Kim <>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at