Re: [Xen-devel] [PATCH 2/2] m2p_find_override: uselist_for_each_entry_safe
From: Stefano Stabellini
Date: Thu Mar 29 2012 - 10:01:46 EST
On Tue, 27 Mar 2012, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 27, 2012 at 05:37:07PM +0100, Stefano Stabellini wrote:
> > On Tue, 27 Mar 2012, Konrad Rzeszutek Wilk wrote:
> > > On Tue, Mar 27, 2012 at 02:52:44PM +0100, Stefano Stabellini wrote:
> > > > Use list_for_each_entry_safe and remove the spin_lock acquisition in
> > > > m2p_find_override.
> > >
> > > So this would allow us to get stale entries. Is that OK?
> > I think it is reasonable.
> > In practice we should never get an m2p_find_override call looking for an
> > entry that we are about to add/delete.
> Why don't you add that in the comment and also fix:
> /home/konrad/ssd/linux/arch/x86/xen/p2m.c: In function
> /home/konrad/ssd/linux/arch/x86/xen/p2m.c:810: warning: unused variable
Ooops. I'll do that.