Re: [PATCH] ftrace: Remove a superfluous check
From: Borislav Petkov
Date: Thu Mar 29 2012 - 13:26:26 EST
On Thu, Mar 29, 2012 at 07:17:19PM +0200, John Kacur wrote:
> It looks okay to me. Technically it's not functionally equivalent
> though, because now when __register_ftrace_function is called
> directly, (in other paths), the test has an unlikely there.
I know, but ftrace_disabled is really unlikely to be set to 1 because
we set it only if ftrace_init() fails and on the panic path in
So I agree that it is not functionally completely equivalent but it
should be correct with the unlikely.
> See what teven says, otherwise, you can have my reviewed by.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/