Re: [PATCH resend] ASPM: Fix pcie devices with non-pcie children
From: Jonathan Nieder
Date: Thu Mar 29 2012 - 17:02:40 EST
Andrew Morton wrote:
> Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
>> From: Matthew Garrett <mjg@xxxxxxxxxx>
>> Date: Tue, 27 Mar 2012 10:17:41 -0400
>> commit 4949be16822e ("PCI: ignore pre-1.1 ASPM quirking
>> when ASPM is disabled") changed the behaviour of
>> pcie_aspm_sanity_check() to always return 0 if aspm is disabled, in
>> order to avoid cases where we changed ASPM state on pre-PCIe 1.1
>> devices. This skipped the secondary function of
>> pcie_aspm_sanity_check which was to avoid us enabling ASPM on devices
>> that had non-PCIe children, causing trouble later on.
>> you pick it up for linux-next until it makes its way to the PCI tree?
> Just about the only person who wasn't copied on this email is, umm, the
> PCI maintainer!
Well spotted. Thanks for catching it.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/