Re: [PATCH 01/14] edac: rewrite the sysfs code to use struct device

From: Greg K H
Date: Thu Mar 29 2012 - 19:40:43 EST

On Thu, Mar 29, 2012 at 08:19:08PM -0300, Mauro Carvalho Chehab wrote:
> > Sweet, as per the documentation in the Documentation/kobjects.txt file,
> > I get to publically mock you for thinking you are smarter than the
> > kernel and this is an acceptable way to "outwhit" the driver core from
> > spitting errors at you when the kobject is released.
> There's nothing there to free: all EDAC structures are allocated once
> (see edac_mc_alloc() and edac_align_ptr() logic, at drivers/edac/edac_mc.c).
> Even the struct device for all csrows/channels/mcu is done on a single alloc
> there. Trying to free it earlier would cause a segfault.

That's wrong then, these are multiple struct devices, all with their own
reference counts, you can't just treat them all as the same thing, even
if it happens to line up with the module reference count.

> I didn't wrote that logic, nor I was tempted to change it: as this subsystem
> is focused on memory error detection, having every data structure used there
> on a single page helps to minimize the probability of having an error at the
> memory used to store the EDAC data.

Possibly, but again, you have multiple reference counts, you can't just
wave them off as being inconvenient. Please read the documentation for
more details why.

greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at