Re: [PATCH 05/13] XFS: Fix lock ASSERT on UP
From: Andi Kleen
Date: Thu Mar 29 2012 - 19:52:11 EST
On Thu, Mar 29, 2012 at 07:21:14PM -0400, Christoph Hellwig wrote:
> On Tue, Mar 27, 2012 at 05:47:09PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > ASSERT(!spin_is_locked()) doesn't work on UP builds. Replace with a standard
> > lockdep_assert_held()
> The "standard" is assert_spin_locked() - which not only is much cheaper
> but also has the advantage of working in non-lockdep builds.
But then you have it unconditional, not just on debug builds.
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/