Re: [PATCH for-3.4-fixes] cgroup: cgroup_attach_task() could return-errno after success
From: Jiri Kosina
Date: Fri Mar 30 2012 - 04:38:07 EST
On Thu, 29 Mar 2012, Tejun Heo wrote:
> 61d1d219c4 "cgroup: remove extra calls to find_existing_css_set" made
> cgroup_task_migrate() return void. An unfortunate side effect was
> that cgroup_attach_task() was depending on that function's return
> value to clear its @retval on the success path. On cgroup mounts
> without any subsystem with ->can_attach() callback,
> cgroup_attach_task() ended up returning @retval without initializing
> it on success.
> For some reason, gcc failed to warn about it and it didn't cause
> cgroup_attach_task() to return non-zero value in many cases, probably
> due to difference in register allocation. When the problem
> materializes, systemd fails to populate /systemd cgroup mount and
> fails to boot.
> Fix it by initializing @retval to zero on declaration.
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Reported-by: Jiri Kosina <jkosina@xxxxxxx>
> LKML-Reference: <alpine.LNX.2.00.1203282354440.25526@xxxxxxxxxxxxx>
> Jiri, can you please confirm the fix?
Thanks Tejun, it works here.
Tested-by: Jiri Kosina <jkosina@xxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/