Re: [PATCH 01/14] edac: rewrite the sysfs code to use struct device
From: Borislav Petkov
Date: Fri Mar 30 2012 - 05:12:33 EST
On Thu, Mar 29, 2012 at 11:13:07PM -0300, Mauro Carvalho Chehab wrote:
> However, every time this patch series is submitted, someone come up with a
> bright idea to ask me to add more work to the scope, delaying its addition
> While I'm not convinced that moving from a single memory allocation into a
> series of k*alloc is a good thing for a subsystem that is there to detect
> memory errors (as having everything altogether into a single page can
> reduce the chances of errors at the EDAC data), I can work latter on a
> patchset to fix this issue for EDAC MC, but I'll do it only after merging
> this series, as it is counter-productive to do it otherwise, having to
> repeat the same set of tests on 10 machines (and compile the entire series
> of patches on 8 different archs/sub-archs).
> So, I really want to move this ahead. So, please, first things first: let's
> first fix the more serious bug. Then, we can fix the other minor stuff
> that aren't so far causing any noticeable harm.
Dude, stop complaining - this is the kernel not some pet project of
yours. You either do things right or you don't do them at all. Others
have to do the same iterations with patches and intergrate maintainer
change requests until everything is done properly.
Btw, this patch is
5 files changed, 432 insertions(+), 717 deletions(-)
It is 1500+ lines and huuuuge! How do you think anyone can review this?
Also, I told already: if you wanna fix one thing, then fix it with a
smaller patchset which easier to review by people instead of throwing at
them humongous patch bombs which are supposed to fix _everything_ and
expecting everyone to understand immediately what you mean. And don't
tell me these huge patches cannot be split, I'm not buying it.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/