Re: [PATCH v6 1/5] Extcon (external connector): import Android'sswitch class and modify.
From: Mark Brown
Date: Fri Mar 30 2012 - 06:08:08 EST
On Thu, Mar 29, 2012 at 03:27:01PM -0700, Erik Gilling wrote:
> On Fri, Mar 9, 2012 at 4:41 AM, Mark Brown
> <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, Feb 27, 2012 at 09:15:35PM +0900, MyungJoo Ham wrote:
> >> +#ifdef CONFIG_ANDROID
> >> + extcon_class = class_create(THIS_MODULE, "switch");
> >> +#else /* !CONFIG_ANDROID */
> >> + extcon_class = class_create(THIS_MODULE, "extcon");
> >> +#endif /* CONFIG_ANDROID */
> > This seems somewhat sad - if ANDROID is turned on the standard ABI
> > vanishes. It'd be much nicer to do this with a symlink (or with
> > symlinks within the android directory if the driver core doesn't support
> > that). That way userspace code can be written to the new ABI and will
> > work on Android systems without ifdefery.
> This won't work if userspace code is receiving uevents through netlink
> and comparing based on the device name which it does in android. Why
That's not really the point here - the point is that the new ABI
vanishes as soon as you turn on the legacy Android ABI. You're right
that the particular fix I suggested has issues but the overall problem
exists and should be dealt with more sensibly.
> change the name at all? Extcon is much more specific than "switch."
> A switch can can be used for more than just external connections such
> as availability of HMDI audio (which is only available once a HDMI
> mode is chosen and the interface is enabled.)
I don't know myself, it was called extcon when first proposed for
mainline. Renaming does have the advantage of indicating to userspace
that this is the mainline, reviewed version and that things might be a
bit different as a result of that review.
Things like the HDMI audio example you cite do seem close enough to the
term to still be useful, they're related to an external connection and
it's state. If you were really worrying about it you might expect HDMI
audio to be reported via something like the ALSA APIs rather than a
totally unrelated ABI like this.
Description: Digital signature