On Thu, 29 Mar 2012, KOSAKI Motohiro wrote:No, I added the test to see if the source and destination has the same number of nodes.
Isnt this the original code by Paul?for_each_node_mask(s, tmp) {I'm confused. Could you please explain why you choose nodes_weight()? On my
+
+ /* IFF there is an equal number of source and
+ * destination nodes, maintain relative node distance
+ * even when source and destination nodes overlap.
+ * However, when the node weight is unequal, never
move
+ * memory out of any destination nodes */
+ if ((nodes_weight(*from_nodes) !=
nodes_weight(*to_nodes))&&
+ (node_isset(s, *to_nodes)))
+ continue;
+
d = node_remap(s, *from_nodes, *to_nodes);
if (s == d)
continue;
first impression,
it seems almostly unrelated factor.
I would think that the 1-1 movementAgreed, thats exactly what this patch does. are you OK with this change then???
is only useful to do if the number of nodes in both the destination and
the source is the same.