Re: [GIT PULL] Btrfs fixes and features

From: Chris Mason
Date: Fri Mar 30 2012 - 16:01:15 EST

On Fri, Mar 30, 2012 at 12:50:26PM -0700, Linus Torvalds wrote:
> On Fri, Mar 30, 2012 at 10:51 AM, Chris Mason <chris.mason@xxxxxxxxxx> wrote:
> >
> > git:// for-linus
> This causes a new warning for me:
> fs/btrfs/extent_io.c: In function ârepair_eb_io_failureâ:
> fs/btrfs/extent_io.c:1940:6: warning: âretâ may be used
> uninitialized in this function

Interesting that my gcc doesn't warn here. Strictly speaking, gcc isn't
wrong, but num_extent_pages() will always be at least 1. This function
is new in this pull, so it can't be a conflict.

Do you want a new pull with the ret = 0 patch?

int repair_eb_io_failure(struct btrfs_root *root, struct extent_buffer
int mirror_num)
struct btrfs_mapping_tree *map_tree = &root->fs_info->mapping_tree;
u64 start = eb->start;
unsigned long i, num_pages = num_extent_pages(eb->start, eb->len);
int ret;

for (i = 0; i < num_pages; i++) {
struct page *p = extent_buffer_page(eb, i);
ret = repair_io_failure(map_tree, start, PAGE_CACHE_SIZE,
start, p, mirror_num);
if (ret)

return ret;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at