Re: [GIT PULL] Btrfs fixes and features

From: Chris Mason
Date: Fri Mar 30 2012 - 16:04:51 EST

On Fri, Mar 30, 2012 at 12:54:03PM -0700, Linus Torvalds wrote:
> On Fri, Mar 30, 2012 at 12:50 PM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > This causes a new warning for me:
> >
> > Âfs/btrfs/extent_io.c: In function ârepair_eb_io_failureâ:
> > Âfs/btrfs/extent_io.c:1940:6: warning: âretâ may be used
> > uninitialized in this function
> >
> > Hmm?
> Ok, so presumably num_pages (which is "num_extent_pages(eb->start,
> eb->len)") cannot be zero, so I guess the code is ok. But gcc can't
> know that, and it's an annoying warning.

Whoops, my reply was too slow, sorry. If you're curious my gcc that
doesn't warn in 4.6.3.

> So please fix, but it's not urgent. In the meantime I've pulled and pushed out.

Ok, I'll send just the incremental in a later pull.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at