[ 055/108] target: Dont set WBUS16 or SYNC bits in INQUIRY response
From: Greg KH
Date: Fri Mar 30 2012 - 18:54:50 EST
3.0-stable review patch. If anyone has any objections, please let me know.
From: Roland Dreier <roland@xxxxxxxxxxxxxxx>
commit effc6cc8828257c32c37635e737f14fd6e19ecd7 upstream.
SPC-4 says about the WBUS16 and SYNC bits:
The meanings of these fields are specific to SPI-5 (see 6.4.3).
For SCSI transport protocols other than the SCSI Parallel
Interface, these fields are reserved.
We don't have a SPI fabric module, so we should never set these bits.
(The comment was misleading, since it only mentioned Sync but the
actual code set WBUS16 too).
Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>
Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
drivers/target/target_core_cdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -106,7 +106,7 @@ target_emulate_inquiry_std(struct se_cmd
- buf = 0x32; /* Sync=1 and CmdQue=1 */
+ buf = 0x2; /* CmdQue=1 */
* Do not include vendor, product, reversion info in INQUIRY
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/