Re: [PATCH 1/8] Documentation: remove 'mach' from dontdiff file

From: Randy Dunlap
Date: Fri Mar 30 2012 - 19:16:06 EST


On 03/30/2012 03:39 PM, Linus Torvalds wrote:

> On Fri, Mar 30, 2012 at 1:36 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
>> From: H Hartley Sweeten <hartleys@xxxxxxxxxxxxxxxxxxx>
>>
>> Documentation: remove mach from dontdiff file
>
> Grr.
>
> Most of these patches have the same stupid problem: why the *hell* do
> you repeat the single-line top-level description in both the Subject
> line and the body of the email? It only results in stupid duplicate
> lines in the commit logs.
>
> This is a disease. I don't know who the heck started doing it, but
> it's WRONG. It's stupid. What broken piece-of-shit tool is it that
> does this braindamage?
>
> Fix it. Stop sending these broken commit messages to people.
>
> I'm grumpy, yes, because this is a common problem. I see it all over
> the place, and it makes our commit logs look f*cking retarded.
>
> If you absolutely need to repeat the subject line in the body of the
> email, do it together with the author line, and mark it as such, ie do
> this:
>
> From: H Hartley Sweeten <hartleys@xxxxxxxxxxxxxxxxxxx>
> Subject: Documentation: remove mach from dontdiff file
>
> so that git sees that it's a repeat of the subject line. Don't just
> put it in the body as another stupid repeat.


I see. Thanks for the info.

Shall I resend all of these?

--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/