Re: [PATCH] m68k: include asm/cmpxchg.h in our m68k atomic.h

From: Geert Uytterhoeven
Date: Sat Mar 31 2012 - 16:02:24 EST

On Sat, Mar 31, 2012 at 21:28, David Howells <dhowells@xxxxxxxxxx> wrote:
> <gerg@xxxxxxxxxxx> wrote:
>> From: Greg Ungerer <gerg@xxxxxxxxxxx>
>> After commit 9ffc93f203c18a70623f21950f1dd473c9ec48cd ("Remove all
>> Â CC Â Â Âinit/main.o
>> In file included from include/linux/mm.h:15:0,
>> Â Â Â Â Â Â Â Â Âfrom include/linux/ring_buffer.h:5,
>> Â Â Â Â Â Â Â Â Âfrom include/linux/ftrace_event.h:4,
>> Â Â Â Â Â Â Â Â Âfrom include/trace/syscall.h:6,
>> Â Â Â Â Â Â Â Â Âfrom include/linux/syscalls.h:78,
>> Â Â Â Â Â Â Â Â Âfrom init/main.c:16:
>> include/linux/debug_locks.h: In function â__debug_locks_offâ:
>> include/linux/debug_locks.h:16:2: error: implicit declaration of function âxchgâ
>> There is no indirect inclusions of the new asm/cmpxchg.h for m68k here.
>> Looking at most other architectures they include asm/cmpxchg.h in their
>> asm/atomic.h. M68k currently does not do this. Including this in atomic.h
>> fixes all m68k build problems.
>> Signed-off-by: Greg Ungerer <gerg@xxxxxxxxxxx>
> Acked-by: David Howells <dhowells@xxxxxxxxxx>

Thanks! I hope to create for-3.4 and for-3.5 branches tomorrow.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at