Re: On patch "Remove all #inclusions of asm/system.h"

From: David Howells
Date: Sat Mar 31 2012 - 21:46:46 EST

Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote:

> It's not a problem; they now get barrier.h via spinlock.h. I just
> wondered whether absence of #include <asm/barrier.h> in those files had a
> deeper non-obvious meaning. Since it doesn't I will just put that include
> in them next time around when I do some housekeeping there.

I suspect they should #include asm/barrier.h directly rather than relying on
spinlock.h. There's no guarantee that on every arch spinlock.h will pull in
asm/barrier.h, I think...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at