Re: [PATCH v3] arch/tile: support multiple huge page sizes dynamically

[Hillf Danton]

On Sat, Mar 31, 2012 at 3:37 AM, Chris Metcalf <cmetcalf@xxxxxxxxxx> wrote:
> This change adds support for a new "super" bit in the PTE, and a
> new arch_make_huge_pte() method called from make_huge_pte().
> The Tilera hypervisor sees the bit set at a given level of the page
> table and gangs together 4, 16, or 64 consecutive pages from
> that level of the hierarchy to create a larger TLB entry.
>
> One extra "super" page size can be specified at each of the
> three levels of the page table hierarchy on tilegx, using the
> "hugepagesz" argument on the boot command line. ÂA new hypervisor
> API is added to allow Linux to tell the hypervisor how many PTEs
> to gang together at each level of the page table.
>
> To allow pre-allocating huge pages larger than the buddy allocator
> can handle, this change modifies the Tilera bootmem support to
> put all of memory on tilegx platforms into bootmem.
>
> As part of this change I eliminate the vestigial CONFIG_HIGHPTE
> support, which never worked anyway, and eliminate the hv_page_size()
> API in favor of the standard vma_kernel_pagesize() API.
>
> Reviewed-by: Hillf Danton <dhillf@xxxxxxxxx>
> Signed-off-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>
> ---
> This version of the patch adds a generic no-op definition to
> <linux/hugetlb.h> if "arch_make_huge_pte" is not #defined. ÂI'm following
> Linus's model in https://lkml.org/lkml/2012/1/19/443 which says you create
> the inline, then "#define func func" to indicate that the function exists.
>
> Hillf, let me know if you want to provide an Acked-by, or I'll leave it
> as Reviewed-by. ÂI'm glad you didn't like the v2 patch;
>
Frankly I like this work, if merged, many tile users benefit.

And a few more words,
1, the Reviewed-by tag does not match what I did, really, and
over 98% of this work should be reviewed by tile gurus IMO.

2, this work was delivered in a monolithic huge patch, and it is hard
to be reviewed. The rule of thumb is to split it into several parts, then
reviewers read a good story, chapter after another.

3, I look forward to reading the mm/hugetlb.c chapter.

Good weekend
-hd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/