Re: [PATCH] sky2: dont overwrite settings for PHY Quick link

From: David Miller
Date: Mon Apr 02 2012 - 18:42:10 EST


From: Stephen Hemminger <shemminger@xxxxxxxxxx>
Date: Mon, 2 Apr 2012 15:38:18 -0700

> On Fri, 30 Mar 2012 19:28:59 +0200
> Lino Sanfilippo <LinoSanfilippo@xxxxxx> wrote:
>
>> This patch corrects a bug in function sky2_open() of the Marvell Yukon 2 driver
>> in which the settings for PHY quick link are overwritten.
>>
>> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@xxxxxx>
...
> Acked-by: Stephen Hemminger <shemminger@xxxxxxxxxxx>

Applied and queued up for -stable.

> Surprised that gcc did not detect the "or" of uninitialized value.

Especially since it warns for so much crap it shouldn't :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/