Re: [PATCH] marvell sky2 driver: fix so it works without unalignedaccesses

From: Stephen Hemminger
Date: Tue Apr 03 2012 - 12:18:03 EST


On Tue, 3 Apr 2012 11:13:56 -0400
Chris Metcalf <cmetcalf@xxxxxxxxxx> wrote:

> The driver uses a receive_new() routine that ends up requiring unaligned
> accesses in IP header processing. If the architecture doesn't support
> efficient unaligned accesses, just copy all ingress packets to the bounce
> buffers instead.
>
> This allows the driver to be used on the Tilera TILEmpower-Gx, since
> the tile architecture doesn't currently handle kernel unaligned accesses,
> just userspace.
>
> Signed-off-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>

There are many other encapsulation cases where IP header won't be
aligned. Why not just set copybreak module option to a very large value?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/