Re: [PATCH] procfs: use more apprioriate types when dumping/proc/N/stat

[Jan Engelhardt]

On Thursday 2012-03-22 22:57, Andrew Morton wrote:
>On Wed, 21 Mar 2012 15:12:16 +0100 Jan Engelhardt wrote:
>> @@ -463,8 +463,8 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
>>  	start_time = nsec_to_clock_t(start_time);
>>  
>>  	seq_printf(m, "%d (%s) %c %d %d %d %d %d %u %lu \
>> -%lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \
>> -%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld %lu %lu %lu\n",
>> +%lu %lu %lu %ld %ld %ld %ld %d %d %d 0 %llu %lu %lu %lu %lu %lu %lu %lu \
>> +%lu %lu %lu %lu %lu %lu 0 0 %d %d %u %u %llu %lu %ld %lu %lu %lu\n",
>>  		pid_nr_ns(pid, ns),
>>  		tcomm,
>>  		state,
>
>When trying to review this I went completely crosseyed then fell on
>the floor.  Which is why this code got ripped out and redone in
>linux-next, against which I'll ask you to redo the patch, please.