Re: [rtc-linux] [PATCH 1/2 RFC] rtc: Add ioctl to get/clear batterylow voltage status

[Andrew Morton]

On Tue, 14 Feb 2012 17:13:44 +0100
Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx> wrote:

> Currently there is no generic way to get the RTC battery status within
> an application. So add an ioctl to read the status bit.
> The idea is that the bit is set once a low voltage is detected. It stays
> there until it is reset using the RTC_VL_CLR ioctl.
> 
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  include/linux/rtc.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/rtc.h b/include/linux/rtc.h
> index 93f4d03..1a6ec5f 100644
> --- a/include/linux/rtc.h
> +++ b/include/linux/rtc.h
> @@ -91,6 +91,9 @@ struct rtc_pll_info {
>  #define RTC_PLL_GET	_IOR('p', 0x11, struct rtc_pll_info)  /* Get PLL correction */
>  #define RTC_PLL_SET	_IOW('p', 0x12, struct rtc_pll_info)  /* Set PLL correction */
>  
> +#define RTC_VL_READ	_IOR('p', 0x13, int)	/* Voltage low detector */
> +#define RTC_VL_CLR	_IO('p', 0x14)		/* Clear voltage low information */
> +
>  /* interrupt flags */
>  #define RTC_IRQF 0x80	/* Any of the following is active */
>  #define RTC_PF 0x40	/* Periodic interrupt */

Looks good to me, but I'd like to hear from other RTC driver
maintainers, please.

Which other devices provide support for reading the batttery status,
and is the proposed interface suitable for their drivers?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/