Re: BUG at cpuidle_play_dead

From: Boris Ostrovsky
Date: Thu Apr 05 2012 - 17:11:16 EST


On 04/05/12 17:03, Jiri Slaby wrote:
Hi,

I'm hitting this BUG as the last thing during shutdown:
BUG: unable to handle kernel NULL pointer dereference at 00000000000002d8
IP: [<ffffffff814ab60d>] cpuidle_play_dead+0x1d/0xb0


It's because drv is NULL. The problem is gone if I do this:
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -83,6 +83,11 @@ int cpuidle_play_dead(void)
int i, dead_state = -1;
int power_usage = -1;

+ if (!drv) {
+ printk("DRIVER IS NULL\n");
+ return -ENODEV;
+ }
+
/* Find lowest-power state that supports long-term idle */
for (i = CPUIDLE_DRIVER_STATE_START; i< drv->state_count; i++) {
struct cpuidle_state *s =&drv->states[i];

thanks,


This was already fixed in https://lkml.org/lkml/2012/3/31/249.

Len, please apply that patch.

Thanks.
-boris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/