Re: [PATCH] LEDS: LED module for DA9052/53 PMIC v2

[Andrew Morton]

On Wed, 22 Feb 2012 18:39:09 +0530
Ashish Jangam <ashish.jangam@xxxxxxxxxxxxxxx> wrote:

> LED Driver for Dialog Semiconductor DA9052/53 PMICs.
> 
> Signed-off-by: David Dajun Chen <dchen@xxxxxxxxxxx>

This email was cc'ed to Dajun.Chen@xxxxxxxxxxxx  I'll assume that both
work correctly.

>  drivers/leds/Kconfig       |    8 ++
>  drivers/leds/Makefile      |    1 +
>  drivers/leds/leds-da9052.c |  214 ++++++++++++++++++++++++++++++++++++++++++++

Looks OK.  I added one little fixup:

--- a/drivers/leds/leds-da9052.c~leds-led-module-for-da9052-53-pmic-v2-fix
+++ a/drivers/leds/leds-da9052.c
@@ -40,7 +40,7 @@ struct da9052_led {
 	int brightness;
 };
 
-unsigned char led_reg[] = {
+static unsigned char led_reg[] = {
 	DA9052_LED_CONT_4_REG,
 	DA9052_LED_CONT_5_REG,
 };

This array could actually be made static within da9052_set_led_brightness().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/