Re: [PATCH 08/15] perf/events: Correct size given to memset

From: Borislav Petkov
Date: Fri Apr 06 2012 - 08:00:54 EST


On Fri, Apr 06, 2012 at 01:24:41PM +0200, Borislav Petkov wrote:
> On Fri, Apr 06, 2012 at 12:47:59AM +0200, Frederic Weisbecker wrote:
> > From: Julia Lawall <julia@xxxxxxx>
> >
> > This is a forward port of commit 5660ce34241ab
> > perf tools: Correct size given to memset
> > written by Julia Lawall and forward ported by Steven Rostedt.
> >
> > Signed-off-by: Julia Lawall <julia@xxxxxxx>
> > Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxx>
> > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> > Cc: Arun Sharma <asharma@xxxxxx>
> > Cc: Namhyung Kim <namhyung.kim@xxxxxxx>
> > Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > ---
> > tools/lib/traceevent/event-parse.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> > index f012395..16da20c 100644
> > --- a/tools/lib/traceevent/event-parse.c
> > +++ b/tools/lib/traceevent/event-parse.c
> > @@ -2076,7 +2076,7 @@ process_fields(struct event_format *event, struct print_flag_sym **list, char **
> > goto out_free;
> >
> > field = malloc_or_die(sizeof(*field));
> > - memset(field, 0, sizeof(field));
> > + memset(field, 0, sizeof(*field));
>
> This one is already upstream, you can drop it: 5660ce34241ab

Uf, nevermind, you're forward-porting those.

--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/