Re: [PATCH 1/1] pinctrl: fix pinmux_check_ops error checking

From: Viresh Kumar
Date: Sun Apr 08 2012 - 23:32:28 EST


On 4/6/2012 9:02 PM, Stephen Warren wrote:
> On 04/06/2012 06:18 AM, Dong Aisheng wrote:
>> > From: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
>> >
>> > Do not use get_functions_count before checking.
>> >
>> > Signed-off-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
> Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx>
>
> IIRC, Viresh added some other get_*_count() functions in the same patch.
> Do we need any more fixes similar to the this for those too?

Might not be required as this patch handles the pinmux_check_ops() routine.
At other places ops is guaranteed to have correct value.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/