Re: [PATCH 3/5] drivers/net: remove IS_ENABLED usage from wiznetdrivers

[Stephen Rothwell]

Hi Dave,

On Wed, 11 Apr 2012 19:54:44 -0400 (EDT) David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> Date: Wed, 11 Apr 2012 19:50:55 -0400
> 
> > The use of IS_ENABLED in C code (vs just in CPP #if directives)
> > causes us to carry the burden of a huge autoconf.h file.  It is
> > also misleading in that a casual inspection of the code would
> > leave one thinking that the if statements were evaluated at
> > runtime, when TX_FLOW is a Kconfig bool and hence evaluated
> > at configure time as an either/or.
> > 
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> 
> Want me to toss this into net-next?

Sure - *after* it has been reviewed, and tested :-)

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature