Re: [PATCH] virtio_ring: remove unused code in virtqueue_notify()

From: Stefan Hajnoczi
Date: Fri Apr 13 2012 - 04:45:51 EST


On Fri, Apr 13, 2012 at 11:26:03AM +0800, zwu.kernel@xxxxxxxxx wrote:
> From: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
>
> Signed-off-by: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/virtio/virtio_ring.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 5aa43c3..c6a54e6 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -343,8 +343,6 @@ EXPORT_SYMBOL_GPL(virtqueue_kick_prepare);
> */
> void virtqueue_notify(struct virtqueue *_vq)
> {
> - struct vring_virtqueue *vq = to_vvq(_vq);
> -
> /* Prod other side to tell it about changes. */
> vq->notify(_vq);

vq->notify() uses 'vq'. How does this work?

Stefan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/