Re: [PATCH 1/2] drm/i915/intel_i2c: handle zero-length reads

From: Chris Wilson
Date: Fri Apr 13 2012 - 08:25:47 EST


On Fri, 13 Apr 2012 19:47:53 +0800, Daniel Kurtz <djkurtz@xxxxxxxxxxxx> wrote:
> A common method of probing an i2c bus is trying to do a zero-length read.
> Handle this case by checking the length first waiting for data to be read.
>
> This is actually important, since attempting a zero-length read is one
> of the ways that i2cdetect and i2c_new_probed_device detect whether
> there is device present on the bus with a given address.
>
> Signed-off-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>

You earlier assuaged my fears that setting SW_READY without waiting
would anger the hw, so

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/