Re: [PATCH 1/1] checkpatch.pl: thou shalt not use () or (...) infunction declarations

From: H. Peter Anvin
Date: Mon Apr 16 2012 - 02:12:59 EST


On 03/26/2012 03:03 AM, Pedro Alves wrote:
> On 03/22/2012 05:17 PM, Nick Bowler wrote:
>
>> GCC will not normally warn about the above (unless you pass
>> -Wold-style-definition) which warns for all function definitions that
>> lack a prototype.
>
>
> /me asks the stupid question:
>
> Why not make the compiler catch this instead then, with -Werror=old-style-definition?
>

Sounds like a good thing to do.

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/