Re: [PATCH 1/1] pinctrl: handle dummy state in core

From: Stephen Warren
Date: Mon Apr 16 2012 - 12:03:35 EST


On 04/16/2012 08:24 AM, Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
>
> Remove dummy state user interface and handle it totally in core.
> This can make it more easy to use by platforms which has neither pinctrl
> driver support nor dt support.
>
> Signed-off-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>

I think this is the wrong direction.

I specifically want people to think about which drivers require what
pinctrl states to be defined, and what their content should be, and
hence explicitly define dummy states when it's appropriate. This patch
prevents that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/