Re: [PATCH v2] mfd: asic3: Avoid unbalanced irq wakeupenables/disables

From: Samuel Ortiz
Date: Mon Apr 16 2012 - 12:31:19 EST


Hi Paul,

On Wed, Apr 11, 2012 at 12:35:34AM +0100, Paul Parsons wrote:
> The mfd/asic3 driver does not currently define a irq_set_wake() handler.
> Consequently any attempt to configure the 3 ASIC3 GPIO buttons - RECORD,
> CALENDAR, HOME - as wakeup sources results in Unbalanced IRQ warnings
> when the system is woken from sleep mode:
>
> WARNING: at kernel/irq/manage.c:520 irq_set_irq_wake+0xc4/0xf8()
> Unbalanced IRQ 342 wake disable
> ...
> WARNING: at kernel/irq/manage.c:520 irq_set_irq_wake+0xc4/0xf8()
> Unbalanced IRQ 337 wake disable
> ...
> WARNING: at kernel/irq/manage.c:520 irq_set_irq_wake+0xc4/0xf8()
> Unbalanced IRQ 339 wake disable
> ...
>
> This patch adds a irq_set_wake() handler to the mfd/asic3 driver.
>
> Signed-off-by: Paul Parsons <lost.distance@xxxxxxxxx>
> Cc: Philipp Zabel <philipp.zabel@xxxxxxxxx>
> ---
>
> V2:
> This patch now adds asic3_gpio_irq_set_wake() to mfd/asic3 instead of
> disabling the 3 ASIC3 GPIO buttons as wakeup sources in pxa/hx4700.
> This patch now submitted to linux-kernel instead of linux-arm-kernel.
> Rebased from linux-2.6.39-rc6 to linux-3.4-rc2.
Thanks, patch applied as well.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/