Re: [PATCH V3 1/2] mfd: Add driver for STA2X11 MFD block

[Samuel Ortiz]

Hi Alessandro,

On Thu, Apr 12, 2012 at 10:48:44AM +0200, Alessandro Rubini wrote:
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 29f463c..c194c67 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -873,6 +873,12 @@ config MFD_RC5T583
>  	  Additional drivers must be enabled in order to use the
>  	  different functionality of the device.
>  
> +config MFD_STA2X11
> +	bool "STA2X11 multi function device support"
> +	depends on STA2X11
> +	select MFD_CORE
> +	select GPIO_STA2X11
So you haven't fixed that one:

- You should not select GPIO_STA2X11 as this won't select the STA2X211 gpio
  driver dependencies for you. So if you build this driver with GPIOLIB=n then
  your build will fail.
- Why would this one depend on STA2X11 ? I see that you're calling
  sta2x11_get_instance() from this driver but I wonder if you could simply
  replace the mfd->instance pointer with one pointing to the pci_dev. Not
  depending on STA2X11 at all gives you the benefit of a much larger build
  coverage from linux-next for example.


> +/* Bar 0 */
> +enum bar0_cells {
> +	GPIO_0 = 0,
> +	GPIO_1,
> +	GPIO_2,
> +	GPIO_3,
> +	SCTL,
> +	SCR,
> +	TIME,
> +};
Please protect those ones with a proper namespace.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/