Re: [REGRESSION] rtc/interface.c: kills suspend-to-ram

[John Stultz]

On 04/16/2012 08:57 AM, Mark Lord wrote:
> On 12-04-16 11:49 AM, richard -rw- weinberger wrote:
> > On Mon, Apr 16, 2012 at 5:42 PM, Mark Lord<kernel@xxxxxxxxxxxx>  wrote:
> > > On 12-04-16 10:23 AM, richard -rw- weinberger wrote:
> > > > On Mon, Apr 16, 2012 at 3:55 PM, Mark Lord<kernel@xxxxxxxxxxxx>  wrote:
> > > > > On 12-04-16 12:36 AM, Mark Lord wrote:
> > > > > > Something recent has killed suspend-to-ram on a number of machines here.
> > > > > > The symptom is that they suspend, but immediately wake up and panic,
> > > > > > with just a black screen so no visible messages to go by.
> > > > > >
> > > > > > The patch below works around the issue -- making things work as they used to work.
> > > > > >
> > > > > > +++ linux/drivers/rtc/interface.c     2012-04-16 00:09:14.105387382 -0400
> > > > > > @@ -773,7 +773,7 @@
> > > > > >        if (!rtc->ops || !rtc->ops->alarm_irq_enable)
> > > > > >                return;
> > > > > >
> > > > > > -     rtc->ops->alarm_irq_enable(rtc->dev.parent, false);
> > > > > > +     //rtc->ops->alarm_irq_enable(rtc->dev.parent, false);  // Kills suspend on ZBOX HD-ID41U
> > > > > >   }
> > >
> > > How about the line above -- that's the commit that breaks things here.
> > Download Linus' GIT tree and use git blame. :-)
> Too steep a learning curve for a casual user.
> But google works:
>
> http://www.mail-archive.com/stable@xxxxxxxxxxxxxxx/msg04391.html

Thanks for the report and sorry for the trouble.  I'm trying to 
reproduce this locally. Can you send me your .config?

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/