Re: [PATCH 1/6] ACPI: D3cold state is always valid

[Lin Ming]

(fix Len's address)

On Tue, 2012-04-17 at 22:29 +0200, Rafael J. Wysocki wrote:
> On Tuesday, April 17, 2012, Lin Ming wrote:
> > ACPI_STATE_D3 actually means ACPI D3hot which is not always valid.
> > Instead, ACPI D3cold is always valid.
> > 
> > Signed-off-by: Lin Ming <ming.m.lin@xxxxxxxxx>
> 
> Can you just introduce ACPI_STATE_D3_HOT and redefine D3_COLD so that
> it's the same as D3, as I said?

Do you mean below?

diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h
index eba6604..f0b25c8 100644
--- a/include/acpi/actypes.h
+++ b/include/acpi/actypes.h
@@ -499,9 +499,9 @@ typedef u64 acpi_integer;
 #define ACPI_STATE_D0                   (u8) 0
 #define ACPI_STATE_D1                   (u8) 1
 #define ACPI_STATE_D2                   (u8) 2
-#define ACPI_STATE_D3                   (u8) 3
-#define ACPI_STATE_D3_COLD              (u8) 4
-#define ACPI_D_STATES_MAX               ACPI_STATE_D3_COLD
+#define ACPI_STATE_D3_HOT               (u8) 3
+#define ACPI_STATE_D3                   (u8) 4
+#define ACPI_D_STATES_MAX               ACPI_STATE_D3
 #define ACPI_D_STATE_COUNT              5
 
 #define ACPI_STATE_C0                   (u8) 0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/