Re: 3.4.0-rc2: skb_put() -> skb_over_panic

From: Alexander Beregalov
Date: Wed Apr 18 2012 - 03:54:13 EST


>> > Thanks a lot, I belive I know where the problem is.
>> >
>> > Could you check if commit a21d45726acacc963d8baddf74607d9b74e2b723
>> > (tcp: avoid order-1 allocations on wifi and tx path)
>> > was in your tree ?
>> >
>>
>> It was,
>> git show a21d4572 v3.4-rc2..668ce0a
>> shows it
>
> Thansk for the confirmation.
>
> Had you see the patch I sent some hours ago, and can you test it ?
>
> If not, I probably can reproduce the problem in my lab.
>
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 376b2cf..7ac6423 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -1096,6 +1096,7 @@ static void __pskb_trim_head(struct sk_buff *skb, int len)
> Â Â Â Âeat = min_t(int, len, skb_headlen(skb));
> Â Â Â Âif (eat) {
> Â Â Â Â Â Â Â Â__skb_pull(skb, eat);
> + Â Â Â Â Â Â Â skb->avail_size -= eat;
> Â Â Â Â Â Â Â Âlen -= eat;
> Â Â Â Â Â Â Â Âif (!len)
> Â Â Â Â Â Â Â Â Â Â Â Âreturn;
>
>

Yes, I am testing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/