Re: [PATCH v2 3/8] ARM: LPC32xx: clock.c update

From: Roland Stigge
Date: Wed Apr 18 2012 - 04:33:59 EST


On 04/17/2012 11:09 PM, Dan Carpenter wrote:
> On Tue, Apr 17, 2012 at 07:08:22PM +0200, Roland Stigge wrote:
>> Besides switching to the default macro CLKDEV_INIT() for clock registration,
>> this patch actually updates the clock registrations of pl08xdmac.
>>
>
> When there is a cleanup and a new feature added in the same patch,
> it makes it hard to read... :/ So when we update pl08xdmac:
>
> - CLKDEV_INIT(NULL, "clk_dmac", &clk_dma),
> + CLKDEV_INIT("pl08xdmac", NULL, &clk_dma),
>
> What does that actually do? Is it a bug fix?

The primecell DMA driver refers to this clock via "pl08xdmac", so it
only works with the above line change. Will separate out to another patch.

Thanks,

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/