RE: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deepsleep

[Li Yang-R58472]

> On Wed, Feb 29, 2012 at 07:45:23PM +0100, Wolfram Sang wrote:
> > Hi,
> >
> > On Wed, Feb 29, 2012 at 06:39:21PM +0800, Zhao Chenhui wrote:
> > > When entering deep sleep, the value in the registers I2CFDR and
> > > I2CDFSRR are lost. This causes I2C access to fail after resuming.
> > >
> > > Add suspend/resume routines to save/restore the registers I2CFDR and
> > > I2CDFSRR.
> > >
> > > Signed-off-by: Zhao Chenhui <chenhui.zhao@xxxxxxxxxxxxx>
> > > Signed-off-by: Li Yang <leoli@xxxxxxxxxxxxx>
> > > ---
> > >  drivers/i2c/busses/i2c-mpc.c |   34
> +++++++++++++++++++++++++++++++++-
> > >  1 files changed, 33 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/i2c/busses/i2c-mpc.c
> > > b/drivers/i2c/busses/i2c-mpc.c index a8ebb84..f95a647 100644
> > > --- a/drivers/i2c/busses/i2c-mpc.c
> > > +++ b/drivers/i2c/busses/i2c-mpc.c
> > > @@ -1,7 +1,9 @@
> > >  /*
> > >   * (C) Copyright 2003-2004
> > >   * Humboldt Solutions Ltd, adrian@xxxxxxxxxxxxxxx
> > > -
> > > + *
> > > + * Copyright 2012 Freescale Semiconductor, Inc.
> > > + *
> >
> > I'd think the change is too trivial to claim copyright on the file.
> 
> Do you want to resend with the comments addressed?

We have a company policy for adding copyright claims.  And this patch has met our criteria that requires adding copyright.

We certainly don't want the policy to be against the common practice of the community.  If it is we can consider changing our policy.  However I can't find a clear message stating the consensus of what the Linux kernel community think of adding copyright claims.  I even found some message that encourage adding copyright to maintain the GPL license.

- Leo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/