Re: [PATCH] drm/radeon/kms: fix the regression of DVI connector check

[Alex Deucher]

On Wed, Apr 18, 2012 at 9:21 AM, Takashi Iwai <tiwai@xxxxxxx> wrote:
> The check of the encoder type in the commit [e00e8b5e: drm/radeon/kms:
> fix analog load detection on DVI-I connectors] is obviously wrong, and
> it's the culprit of the regression on my workstation with DVI-analog
> connection resulting in the blank output.
>
> Fixed the typo now.
>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
>  drivers/gpu/drm/radeon/radeon_connectors.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
> index bd05156..aa8268d 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -970,7 +970,7 @@ radeon_dvi_detect(struct drm_connector *connector, bool force)
>
>                        encoder = obj_to_encoder(obj);
>
> -                       if (encoder->encoder_type != DRM_MODE_ENCODER_DAC ||
> +                       if (encoder->encoder_type != DRM_MODE_ENCODER_DAC &&
>                            encoder->encoder_type != DRM_MODE_ENCODER_TVDAC)
>                                continue;
>
> --
> 1.7.9.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/