Re: [tip:x86/x32] x32: Fix alignment fail in struct compat_siginfo

[H.J. Lu]

On Wed, Apr 18, 2012 at 4:48 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 04/18/2012 03:55 PM, H.J. Lu wrote:
>> On Wed, Apr 18, 2012 at 2:24 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>>> Something like this works for you?
>>>
>>> Note: we should promote __compat_[us]64 to a global type when we do the
>>> cleanup work requested by Linus (change __[us]64 to explicitly aligned
>>> types, with all users that require the old types using __compat_[us]64),
>>> but we need the compiler warning to do that, realistically.
>>>
>>
>> Can we also align struct siginfo to 8byte for x32?
>>
>
> We could.  If we want to align the substructures then we need some major
> surgery to the compat_siginfo handling though.
>

Since there will be no x32 kernel, align struct siginfo to 8byte for x32
will only be for user space code.  It shouldn't be a problem for kernel.


-- 
H.J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/