Re: [PATCH] spi/ep93xx: clean probe/remove routines

From: Mika Westerberg
Date: Thu Apr 19 2012 - 02:20:45 EST


On Wed, Apr 18, 2012 at 11:09:18AM -0500, H Hartley Sweeten wrote:
> But, I really don't think we actually gain anything by displaying the
> memory and irq. Maybe this would be more useful:
>
> dev_info(&pdev->dev, "EP93xx SPI Controller using %s\n",
> espi->dma_tx ? "DMA" : "PIO");
>
> That way the user knows at boot time if the spi controller is using DMA or PIO.
>
> Mika, what do you think?

I agree, having the driver to print whether DMA or PIO is used brings more
value than it is currently doing. However, that is a subject of a separate
patch not this one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/