Re: [patch 03/18] smp: Add generic smpboot facility

From: Yinghai Lu
Date: Fri Apr 20 2012 - 16:07:21 EST


On Fri, Apr 20, 2012 at 6:05 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> Start a new file, which will hold SMP and CPU hotplug related generic
> infrastructure.
>
===================================================================
> --- linux-2.6.orig/kernel/cpu.c
> +++ linux-2.6/kernel/cpu.c
> @@ -17,6 +17,8 @@
>  #include <linux/gfp.h>
>  #include <linux/suspend.h>
>
> +#include "smpboot.h"
> +
>  #ifdef CONFIG_SMP
>  /* Serializes the updates to cpu_online_mask, cpu_present_mask */
>  static DEFINE_MUTEX(cpu_add_remove_lock);
> @@ -300,6 +302,11 @@ static int __cpuinit _cpu_up(unsigned in
>                return -EINVAL;
>
>        cpu_hotplug_begin();
> +
> +       ret = smpboot_prepare(cpu);
> +       if (ret)
> +               goto out;
> +
>        ret = __cpu_notify(CPU_UP_PREPARE | mod, hcpu, -1, &nr_calls);
>        if (ret) {
>                nr_calls--;
> @@ -320,6 +327,7 @@ static int __cpuinit _cpu_up(unsigned in
>  out_notify:
>        if (ret != 0)
>                __cpu_notify(CPU_UP_CANCELED | mod, hcpu, nr_calls, NULL);
> +out:
>        cpu_hotplug_done();
>
>        return ret;
> Index: linux-2.6/kernel/smpboot.c
> ===================================================================
> --- /dev/null
> +++ linux-2.6/kernel/smpboot.c
> @@ -0,0 +1,12 @@
> +/*
> + * Common SMP CPU bringup/teardown functions
> + */
> +
> +#include "smpboot.h"
> +
> +/**
> + * smpboot_prepare - generic smpboot preparation
> + */
> +int __cpuinit smpboot_prepare(unsigned int cpu)
> +{
return 0;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/