Re: [PATCH 1/2] i2c-eg20t: add helper function for xfer check

From: Wolfram Sang
Date: Fri Apr 20 2012 - 16:39:43 EST


On Thu, Apr 19, 2012 at 03:38:04PM +0900, Tomoya MORINAGA wrote:
> Currently, there are the same code for xfer complete check processing.
> So, I add helper function pch_i2c_wait_for_check_xfer.
>
> Reported-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@xxxxxxxxx>

Both applied to next, thanks for doing this! ~120 lines saved, that's
about 10%. And also way better maintainable, yay.

My checkers found some other issues, for which I will send patches in a
minute. Please have a look and test.

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature