Re: [PATCH 3/4] android-alarm: Rework alarm-dev.c to use upstreamedalarmtimers

[Greg KH]

On Fri, Apr 20, 2012 at 12:31:46PM -0700, John Stultz wrote:
> This reworks the alarm-dev.c to use the upstreamed alarmtimers
> interface.
> 
> CC: Colin Cross <ccross@xxxxxxxxxxx>
> CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> CC: Android Kernel Team <kernel-team@xxxxxxxxxxx>
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> ---
>  drivers/staging/android/alarm-dev.c |  108 +++++++++++++++++++++++++++++++---
>  1 files changed, 98 insertions(+), 10 deletions(-)

After this patch, I get the following warnings:

  CC      drivers/staging/android/alarm-dev.o
drivers/staging/android/alarm-dev.c: In function âdevalarm_startâ:
drivers/staging/android/alarm-dev.c:93:3: warning: passing argument 1 of âalarm_startâ from incompatible pointer type [enabled by default]
include/linux/alarmtimer.h:46:6: note: expected âstruct alarm *â but argument is of type âstruct android_alarm *â
drivers/staging/android/alarm-dev.c: In function âalarm_dev_initâ:
drivers/staging/android/alarm-dev.c:354:2: warning: passing argument 3 of âandroid_alarm_initâ from incompatible pointer type [enabled by default]
drivers/staging/android/android_alarm.h:69:6: note: expected âvoid (*)(struct android_alarm *)â but argument is of type âenum alarmtimer_restart (*)(struct android_alarm *, union ktime_t)â
drivers/staging/android/alarm-dev.c:358:2: warning: passing argument 3 of âandroid_alarm_initâ from incompatible pointer type [enabled by default]
drivers/staging/android/android_alarm.h:69:6: note: expected âvoid (*)(struct android_alarm *)â but argument is of type âenum alarmtimer_restart (*)(struct android_alarm *, union ktime_t)â

Care to send a patch that fixes this up as well, as odds are, something just
went wrong...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/