Re: [Patch] Touch: DA9052/53 touch screen driver v2

From: Dmitry Torokhov
Date: Sat Apr 21 2012 - 02:38:59 EST


Hi Ashish,

On Fri, Apr 20, 2012 at 05:58:45PM +0530, Ashish Jangam wrote:
> +static irqreturn_t da9052_ts_pendwn_irq(int irq, void *data)
> +{
> + struct da9052_tsi *tsi = data;
> +
> + if (!tsi->stopped) {
> + /* Mask PEN_DOWN event and unmask TSI_READY event */
> + disable_irq_nosync(tsi->da9052->irq_base + tsi->irq_pendwn);
> + enable_irq(tsi->da9052->irq_base + tsi->irq_datardy);

Why did you switch to using irq_base here? da9052_onkey driver does not
do that, should it?

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/