Re: [PATCH 06/12] perf/x86-ibs: Precise event sampling with IBS forAMD CPUs

[Robert Richter]

On 14.04.12 12:24:58, Peter Zijlstra wrote:
> On Mon, 2012-04-02 at 20:19 +0200, Robert Richter wrote:
> > +       switch (event->attr.type) {
> > +       case PERF_TYPE_HARDWARE:
> > +               switch (event->attr.config) {
> > +               case PERF_COUNT_HW_CPU_CYCLES:
> > +                       *config = 0;
> > +                       return 0;
> > +               }
> > +               break;
> > +       case PERF_TYPE_RAW:
> > +               switch (event->attr.config) {
> > +               case 0x0076:
> > +                       *config = 0;
> > +                       return 0;
> > +               case 0x00C1:
> > +                       *config = IBS_OP_CNT_CTL;
> > +                       return 0;
> > +               }
> > +               break;
> > +       default:
> > +               return -ENOENT;
> > +       } 
> 
> Another option would be to do this from amd_pmu_hw_config() after you've
> already gotten rid of the whole attr.type thing.

I didn't want to have IBS setup code in amd_pmu_hw_config(). The
approach to pass the configuration for precise sampling to the ibs pmu
was the simplest to me.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/