Re: [CRIU] [PATCH v2 0/2] IPC: message queue checkpoint/restore -requested updates

From: Kinsbursky Stanislav
Date: Mon Apr 23 2012 - 06:19:35 EST


Hello, Andrew.
I'm very sorry, but a critical flaw has been found in this feature: copying of kernel data to user is done under spinlock.
Since message queue size can be increased up to INT_MAX, then copying to temporary kernel buffer while passing message queue in not a solution.
So, please, drop both patches (feature implementation and test).
Most probably Ill replace them with MSG_PEEK feature (the same logic, but only for one message - like it's done for sockets).

--
Best regards,
Stanislav Kinsbursky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/