Re: [PATCH 5/9 v2] gpio/nomadik: use ioremap() instead of staticmappings

From: Russell King - ARM Linux
Date: Mon Apr 23 2012 - 07:34:42 EST


On Mon, Apr 23, 2012 at 01:30:32PM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> We were using a custom io_p2v() (physical-to-virtual) translation
> macro, but it's fully possible to just ioremap() this memory
> now, so skip use of static addresses altogether.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> drivers/gpio/gpio-nomadik.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
> index 7b45d88..bddc3dd 100644
> --- a/drivers/gpio/gpio-nomadik.c
> +++ b/drivers/gpio/gpio-nomadik.c
> @@ -28,7 +28,6 @@
>
> #include <plat/pincfg.h>
> #include <plat/gpio-nomadik.h>
> -#include <mach/hardware.h>
> #include <asm/gpio.h>

While you're here, please replace this with linux/gpio.h - which will give
us one less direct dependency on asm/ or mach/ includes from drivers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/